Signed messages #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added default setting to derive compressed public keys when constructing private keys from BigInt
- Initial success in implementing Compact Bitcoin Signatures. Compact Signatures are interesting since you have the ability to recover an associated public key from just the signature. - Refactored the sign() and verify() methods which had what appeared to be "bitcoin-protocol-level" code for "reversed" messages in there. Code was factored out into the signWith() method of transaction.dart
- The original `bsv` library code has this funky 'Buffer' class which dynamically decodes utf8 or base64 data on the fly. We have to be more explicit. The Message() constructor now only accepts a byte array of data for signing. It's up the client to deconstruct their source data into a byte array. Not Message() class' concern.
- Implemented compact bitcoin message signatures and tests Compact Signature format is pretty cool. It allows you to retrieve a user's public key from just the message signature and the signed message. - Implemented above scheme for both compressed and uncompressed public keys - Refactored parts of Address, PublicKey to support this signature scheme. Refactor include fixes for some fugly hacks; most hairy of the latter was the inconsistent handling of _publicKeyHash in the Address class. Address can be further cleaned up. Later.
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcoin Signed Messages implementation including some supporting library refactors.