Skip to content
This repository has been archived by the owner on Jul 10, 2022. It is now read-only.

Deleting a notebook using the docker image causes page to freeze #702

Closed
absolutejam opened this issue Oct 12, 2016 · 13 comments
Closed

Deleting a notebook using the docker image causes page to freeze #702

absolutejam opened this issue Oct 12, 2016 · 13 comments

Comments

@absolutejam
Copy link

I've fired up the docker image(s) via. docker-compose and got up and running.

When I attempt to delete a notebook (Both the default 'Welcome' and one I have created), the page just hangs until I refresh it.

Are there any logs that it would be worth me sending across?

Regards,
James.

@Liongold
Copy link
Contributor

The browser's developer tools console and network tabs should help. Also, please specify which branch you're running.

@absolutejam
Copy link
Author

Can't see anything happening in there. I'm running the master branch as of about a week ago.

I can create new notebooks and notes just fine, and even delete notes but it just freezes when I delete a notebook the page freezes.

Just going to destroy and spin up again and see what happens.

@absolutejam
Copy link
Author

Same again after tearing it down my current containers and using docker-compose up again. I'm using 'db' as the database address - this should be fine, right?

@Liongold
Copy link
Contributor

If you get the notes, then it should be good.

@Liongold
Copy link
Contributor

Can you show a screenshot of the browser's network tab. The request should give at least an error code.

@vsviridov
Copy link

The modal dialog appears, but it is invisible. If you manually remove the "fade" class - it appears.

@Liongold
Copy link
Contributor

Can anyone retry to confirm this bug? It should now be fixed.

@JamborJan
Copy link
Contributor

Hey @Liongold in which branch have you fixed this? I'm going to rebuild my paperwork package and can test this.

Reference: https://github.com/JamborJan/paperwork/issues/47

@JamborJan
Copy link
Contributor

I just tested with the latest master branch and the issue is still present.

@Liongold
Copy link
Contributor

@JamborJan Sorry for the late reply. The pull request was merged to develop. It should be fixed on that branch. If you think master should be updated, feel free to open a pull request.

@JamborJan
Copy link
Contributor

Hey @Liongold it's working like expected. One question: would it be possible to mentione the name of the notebook which will be deleted? This would ensure that nobody accedently deletes the wrong notebook.

@Liongold
Copy link
Contributor

Liongold commented Feb 3, 2017

@JamborJan If it isn't a problem for you, can you open a new issue for your suggestion please. Until some of the pull request get merged, work can't go very far.

@Liongold
Copy link
Contributor

Liongold commented Feb 3, 2017

Also, since @JamborJan has confirmed that it's fixed, this issue will be closed. Thanks for your feedback. If you encounter any issues, please open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants