[#89] [#113] [#124] Focus improvements on dual and tripple cameras #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolbielski
changed the title
karolbielski
changed the title
karolbielski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to different minimum focus distance built in modern cameras it is hard to focus on small barcodes. To improve the fucus it is needed to apply appropriate zoom factor.
Based on sample code from Apple AVCamBarcode: Detecting barcodes and faces
AVCaptureDevice#setRecommendedZoomFactor(forMinimumCodeSize:)method was added to set required zoom factor for desired code size.Additionaly,
AVCaptureDevice.zoomedCameraForQRCode(withMinimumCodeSize:)method was added to choose single wide angle camera and apply zoom factor at once. From my experiments, the focus is a lot better on devices with dual or tripple cameras while scanning codes from short distance.More information can be found in WWDC 2021 session What’s new in camera capture.
Due to usage of Apple sample code I included text of Apple's license.
Fixes #89
Fixes #113
Fixes #124