Add ability to move map to user-entered coordinates using latitude and longitude text fields and button #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user to move the map to the entered coordinates.
ipranay
reviewed
May 12, 2023
|
|
||
| /// Map view to change simulated user's position | ||
| struct LocationView: View { | ||
| @ObservedObject var controller: SimulatorsController | ||
| let simulator: Simulator | ||
|
|
||
| @State private var latitudeText = "37.323056" | ||
| @State private var longitudeText = "-122.031944" | ||
| /// The location that is being simulated | ||
| @State private var currentLocation = MKCoordinateRegion( | ||
| center: CLLocationCoordinate2D(latitude: 37.323056, longitude: -122.031944), |
There was a problem hiding this comment.
Might want to use constants here and in lines 18, 19 to easily change those in the future.
e.g.
DEFAULT_LAT = 37.323056
DEFAULT_LNG = -122.031944
18, 19 become:
@State private var latitudeText = "\(DEFAULT_LAT)"
@State private var longitudeText = "\(DEFAULT_LNG)"
Suggested change
| center: CLLocationCoordinate2D(latitude: 37.323056, longitude: -122.031944), | |
| center: CLLocationCoordinate2D(latitude: DEFAULT_LAT, longitude: DEFAULT_LNG), |
ipranay
approved these changes
May 12, 2023
|
@twostraws We've added latitude and longitude text fields and a button that allows the user to move the map to the entered coordinates. Could you please review it and merge it? |
|
Great job – thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added latitude and longitude text fields and a button that allows the user to move the map to the entered coordinates.
Screen.Recording.2023-05-11.at.4.06.07.PM.mov