Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic CI support #175

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add basic CI support #175

merged 2 commits into from
Oct 5, 2023

Conversation

lechuckcaptain
Copy link
Contributor

@lechuckcaptain lechuckcaptain commented Sep 25, 2023

This adds a very basic CI support to the repo. This should help to avoid to break main after a not so thoroughly tested merges.

Of course the configuration can be expanded and tuned, but it should be a good starting point 馃 .

A sample run can be found here.

This should fix the following error during tests execution: compiling for macOS 11.0, but module 'Control_Room' has a minimum deployment target of macOS 13.0
@lgreydev
Copy link

lgreydev commented Oct 2, 2023

@lechuckcaptain Good job!

@twostraws
Copy link
Owner

Is this okay to merge, or are there more commits to come?

@lechuckcaptain
Copy link
Contributor Author

If it's OK for you it should be ok to merge it. The only strange thing is that I do not see an action run for these changes, but I would guess it's probably because it's your repository and I don't have permission to trigger CI actions until they are properly configured. After it has been merged it should hopefully work 馃

@twostraws
Copy link
Owner

Okay, well let's find out 馃槄

@twostraws twostraws merged commit 00e53cc into twostraws:main Oct 5, 2023
@twostraws
Copy link
Owner

This is merged now 鈥撀爐hank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants