Binary output written to console

[mgeisler]

If you track binary files with Chezmoi, you will see binary output in the termianl when using chezmoi update -v.

I suggest checking if the files contain a NUL byte before printing them to the terminal. That heuristic normally works okay to determine if a file is "binary" or not.

[twpayne]

This isn't supposed to happen. There's a check for whether a file is binary or not before printing the diff. Obviously it's not working. What are the contents of the binary file that's getting printed? A hex dump of the first 512 bytes should be enough for reproducing this bug.

[twpayne]

Relevant commit is f2dfbb8#diff-8e160c67b78164a82112c7af4beb91fe.

[mgeisler]

Oh, I see you're already thought of this! Cool :-)

The files in question were fonts -- Inconsolata Regular and Bold taken from https://fonts.google.com/specimen/Inconsolata.

[mgeisler]

I tried running http.DetectContentType on the first 512 byte of the font, and it answers font/ttf as one would hope: https://play.go-lang.com/p/SQdUxpt0x1E

So I don't know why the font was shown in the terminal.

[twpayne]

Thanks very much for doing the further investigation. I'll close this for now until we can reproduce the problem.