chore: Make generation of versioninfo.json work without tags or git repo #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, well it looks like deivid-rodriguez deleted his fork, but this is still a bug fix :) |
|
Yes, it was just for testing dependabot PR generation, but thanks for caring and fixing these things! |
|
Thank you for your work on dependabot :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, generating
versioninfo.jsonrequiredgit describe --abbrev=0 --tagsto succeed, which is not the case when chezmoi is forked (https://github.com/deivid-rodriguez/chezmoi/pull/2) or if chezmoi is built from a source archive (where there is no git repo). With this commit,versioninfo.jsonis generated in both cases, albeit without a correct version or commit hash. This allows thetest-releasejob to succeed on forks.cc @deivid-rodriguez