Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note about actual auth types for GitHub private repos #2690

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Avendattor
Copy link

Issue on private GitHub repos: URL login is deprecared, SSH used instead.

When connecting to GitHub by URL, there was an error: "Support for password authentication was removed on August 13, 2021. Please see https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication."

Copy link
Collaborator

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https:// will work if you’re using a public dotfiles repo or something other than github.com. Instead of replacing this, an additional paragraph would be better. This would indicate that git@github.com is necessary for private repos.

@bradenhilton
Copy link
Collaborator

bradenhilton commented Jan 13, 2023

A note/info admonition would probably be sufficient over an entire paragraph.

Private GitHub repos requires other
[authentication](https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token):

```console```console
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: looks like ```console got duplicated here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. it was temp commit

added note about actual auth types
@Avendattor Avendattor changed the title docs: changed deprecated login from URL to SSH docs: note about actual auth types for GitHub private repos Jan 24, 2023
@Avendattor
Copy link
Author

Finished (fixed, synced), ready for review

@Avendattor Avendattor requested review from halostatue and twpayne and removed request for halostatue January 24, 2023 09:20
@twpayne twpayne merged commit 492e102 into twpayne:master Jan 24, 2023
@twpayne
Copy link
Owner

twpayne commented Jan 24, 2023

Thank you :)

@Avendattor Avendattor deleted the patch-1 branch January 25, 2023 20:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants