Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump golangci-lint to v1.51.2 #2782

Merged
merged 1 commit into from Feb 20, 2023
Merged

chore: Bump golangci-lint to v1.51.2 #2782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@ env:
AGE_VERSION: 1.1.1
GO_VERSION: '1.20.1'
GOFUMPT_VERSION: 0.4.0
GOLANGCI_LINT_VERSION: 1.51.1
GOLANGCI_LINT_VERSION: 1.51.2
GOVERSIONINFO_VERSION: 1.4.0
jobs:
changes:
Expand Down
10 changes: 6 additions & 4 deletions .golangci.yml
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@ linters:
- asciicheck
- bidichk
- bodyclose
- containedctx
- contextcheck
- decorder
- depguard
Expand All @@ -19,8 +20,8 @@ linters:
- forbidigo
- forcetypeassert
- gci
- gocritic
- gocheckcompilerdirectives
- gocritic
- godot
- goerr113
- gofmt
Expand All @@ -31,6 +32,7 @@ linters:
- gosec
- gosimple
- govet
- grouper
- importas
- ineffassign
- interfacebloat
Expand All @@ -39,6 +41,7 @@ linters:
- loggercheck
- makezero
- misspell
- musttag
- nilerr
- noctx
- nolintlint
Expand All @@ -48,6 +51,7 @@ linters:
- promlinter
- reassign
- revive
- sqlclosecheck
- staticcheck
- stylecheck
- tagliatelle
Expand All @@ -58,12 +62,12 @@ linters:
- unconvert
- unparam
- unused
- usestdlibvars
- whitespace
disable:
- asasalint
- cyclop
- exhaustive
- exhaustivestruct
- exhaustruct
- funlen
- ginkgolinter
Expand All @@ -83,10 +87,8 @@ linters:
- nilnil
- nlreturn
- nonamedreturns
- nosnakecase
- paralleltest
- rowserrcheck # https://github.com/golangci/golangci-lint/issues/2649
- sqlclosecheck # https://github.com/golangci/golangci-lint/issues/2649
- testpackage
- tparallel
- varnamelen
Expand Down
2 changes: 1 addition & 1 deletion internal/cmds/execute-template/main.go
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ var (
)

type gitHubClient struct {
ctx context.Context
ctx context.Context //nolint:containedctx
client *github.Client
}

Expand Down
8 changes: 4 additions & 4 deletions internal/cmds/generate-install.sh/main.go
View file
Open in desktop
Expand Up @@ -65,10 +65,10 @@ func run() error {
}
var goreleaserConfig struct {
Builds []struct {
GOOS []string
GOARCH []string
Ignore []platform
}
GOOS []string `yaml:"goos"`
GOARCH []string `yaml:"goarch"`
Ignore []platform `yaml:"ignore"`
} `yaml:"builds"`
}
if err := yaml.Unmarshal(data, &goreleaserConfig); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/cdcmd.go
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ func (c *Config) runCDCmd(cmd *cobra.Command, args []string) error {
var dir chezmoi.AbsPath
if len(args) == 0 {
dir = c.WorkingTreeAbsPath
} else if argAbsPath, err := chezmoi.NewAbsPathFromExtPath(args[0], c.homeDirAbsPath); err != nil { //nolint:gocritic
} else if argAbsPath, err := chezmoi.NewAbsPathFromExtPath(args[0], c.homeDirAbsPath); err != nil {
return err
} else if argAbsPath == c.DestDirAbsPath {
dir, err = c.getSourceDirAbsPath(nil)
Expand Down