Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle more keepassxc-cli errors #3497

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: Handle more keepassxc-cli errors #3497

merged 1 commit into from
Jan 22, 2024

Conversation

twpayne
Copy link
Owner

@twpayne twpayne commented Jan 20, 2024

Fixes #3487.

Copy link
Collaborator

@halostatue halostatue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have not tested it. Probably best to get it tested before merge.

@twpayne
Copy link
Owner Author

twpayne commented Jan 20, 2024

@MorphBonehunter would you be able to test this? I'm reasonably sure it's reasonably robust, but please find what I've missed.

@twpayne
Copy link
Owner Author

twpayne commented Jan 22, 2024

Actually, I'm pretty sure this is correct. I'll merge it.

@twpayne twpayne merged commit 031b267 into master Jan 22, 2024
18 checks passed
@twpayne twpayne deleted the fix-3487 branch January 22, 2024 00:39
@MorphBonehunter
Copy link

Ok...short trip over the weekend with my family ;)

I've tested the binary from the PRs artifacts and can confirm that both a wrong password and a wrong database leads to an nice error message and the exit of chezmoi.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chezmoi hangs if keepassxc exits with errors in open mode
3 participants