Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bool parse bug #12

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Conversation

LiamWalsh98
Copy link
Contributor

Change the order of attempted observation to avoid ambiguity.

For details, see discussion in #11

@LiamWalsh98
Copy link
Contributor Author

Looks like there are quite a few more tests in internal/ that are failing now. I will have to check on these later. Unless you can in the meantime @twpayne

@twpayne
Copy link
Owner

twpayne commented Oct 12, 2023

It's sufficient to replace the *.gen.go files in internal/tests/ with the new versions.

@twpayne
Copy link
Owner

twpayne commented Oct 12, 2023

You can use the *.gen.go.actual files (generated by the tests, but .gitignored) to directly replace the *.gen.go files.

@LiamWalsh98
Copy link
Contributor Author

Ahh, gotcha. Will do, thanks

@twpayne twpayne merged commit 017df3e into twpayne:master Oct 12, 2023
3 checks passed
@twpayne
Copy link
Owner

twpayne commented Oct 12, 2023

Perfect! Thank you for this excellent contribution and your thoroughness and patience in the contribution process!

@twpayne
Copy link
Owner

twpayne commented Oct 12, 2023

I've tagged v1.1.0 with the changes.

@LiamWalsh98
Copy link
Contributor Author

Awesome, thanks so much for the help and responsiveness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants