Add support for unexpected elements #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrow111
commented
Nov 27, 2023
cbrow111
commented
- Add flag option to enable unexpected element support
- Add flag argument to allow custom unexpected element container name; this allows for proactive prevention of name collisions
- Update to go 1.21
- Add .gitignore
twpayne
requested changes
Nov 27, 2023
generator.go
Outdated
| initializeUnexpectedElements(g.unexpectedElementTypeName) | ||
| options.importPackageNames["encoding/xml"] = struct{}{} | ||
| options.namedTypes = make(map[xml.Name]*element) | ||
| options.namedTypes[xml.Name{Local: g.unexpectedElementTypeName}] = unexpectedElement |
There was a problem hiding this comment.
options.namedTypes is overwritten at at line 231 if g.namedTypes is true.
- Remove unnecessary references to options.namedTypes - Remove unneeded entry in .gitignore
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.