Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react & react-dom to v18 #2838

Merged

Conversation

Aylie-Chou
Copy link
Contributor

@Aylie-Chou Aylie-Chou commented Apr 29, 2024

Issue

[工程] 升級 react 至 v18

Notice

  • replace react-loadable with React.lazy or @loadable/component (ref)
    • upgrade webpack to v4
  • (next PR): replace renderToString with renderToPipeableStream for Suspend supported
  • (next PR): replace velocity-react to react-transition-group since velocity-react has archived and not support react v18 officially
  • (next PR): replace react-helmet with react-helmet-async (ref)

Dependency

twreporter/twreporter-npm-packages#532

@Aylie-Chou Aylie-Chou self-assigned this Apr 29, 2024
@Aylie-Chou Aylie-Chou changed the title feat: upgrade react & react-dom to v18 feat: upgrade react & react-dom to v18 (WIP) May 6, 2024
@Aylie-Chou Aylie-Chou changed the title feat: upgrade react & react-dom to v18 (WIP) feat: upgrade react & react-dom to v18 May 7, 2024
Copy link
Contributor

@liruchen32 liruchen32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aylie-Chou Aylie-Chou force-pushed the 32-feat-upgrade-react-to-v18 branch from 53207e8 to 85b2585 Compare May 8, 2024 09:58
@Aylie-Chou Aylie-Chou merged commit 2962555 into twreporter:master May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants