Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatEmote.id returns NaN when parsed from TwitchPrivateMessage.parseEmotes() #275

Closed
Bauke opened this issue Aug 4, 2021 · 1 comment
Closed
Labels
bug semver-major Issues that need a major version bump to be released (i.e. a breaking change)

Comments

@Bauke
Copy link

Bauke commented Aug 4, 2021

When doing TwitchPrivateMessage.parseEmotes(), the ParsedMessageEmotePart you get have their ids defined as a string, while ChatEmote's ids are number. This ends up making ChatEmote.getUrl() return NaN in the URL: https://static-cdn.jtvnw.net/emoticons/v1/NaN/3.0.

The parseInt here is likely the culprit.

Environment

  • Version: 4.6.4
  • Node version: 16.5.0
@Bauke Bauke added the bug label Aug 4, 2021
@d-fischer d-fischer added the semver-major Issues that need a major version bump to be released (i.e. a breaking change) label Aug 4, 2021
@d-fischer
Copy link
Member

I implemented emotes v2 properly on the main branch and released it as version 5.0.0-pre.16.
There will be no fix for this in the 4.x branch as it's backwards incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug semver-major Issues that need a major version bump to be released (i.e. a breaking change)
Projects
None yet
Development

No branches or pull requests

2 participants