subscribe-message webhook events are not dispached correctly

[OdatNurd]

Bug Report

The event handlers for listening to a subscription ending and listening for a subscription resubscribe both use the same prefix string for their webhook endpoint and signing secret.

As a result, if you want to listen for both events, they both set up a webhook that goes to the same URL, and both events end up at a single endpoint.

Code

The definition of EventSubChannelSubscriptionMessageSubscription.id() is:

    get id(): string {
        return `channel.subscription.end.${this._userId}`;
    }

However, in HelixEventSubApi.subscribeToChannelSubscriptionMessageEvents, the string used is channel.subscription.message:

    return this.createSubscription(
        'channel.subscription.message',
        '1',
        { broadcaster_user_id: extractUserId(broadcaster) },
        transport
    );

Expected behavior

When subscribing to both unsubscribe and subscription-message events, each should be dispatched to their respective handlers, allowing for determining if a subscription is being created or is ending.

Actual Behavior

Both events trigger the same endpoint, requiring the code to examine the event object provided to try and determine which event it's actually receiving

Environment

• Version: twitch-eventsub 4.6.5
• Node version: v14.15.4
• Operating system: Slackware Linux 14.2