Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message id not included in UserNotice #308

Closed
Romybron opened this issue Nov 7, 2021 · 2 comments · Fixed by #309
Closed

Message id not included in UserNotice #308

Romybron opened this issue Nov 7, 2021 · 2 comments · Fixed by #309
Labels

Comments

@Romybron
Copy link
Contributor

Romybron commented Nov 7, 2021

Question /Improvement Request

Hello,

I just noticed while parsing tags that message ID was not included in UserNotice type even tho I can grab it by adding

	get id(): string {
		return this._tags.get('id')!;
	}

to the code, it is present in Twitch docs so how come is it not added ?

Suggestion

Add it to the tags if possible

@itsjusttriz
Copy link

Are you sure your version is up to date? I see it here?

@Romybron
Copy link
Contributor Author

Romybron commented Nov 7, 2021

Hey,

This is TwitchPrivateMessage not UserNotice, please see https://github.com/twurple/twurple/blob/main/packages/chat/src/caps/twitchCommands/messageTypes/UserNotice.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants