Add missing tags for ClearChat and UserNotice
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fischer
requested changes
Nov 8, 2021
| } | ||
|
|
||
| get targetUserId(): string { | ||
| return this._tags.get('target-user-id')!; |
There was a problem hiding this comment.
This isn't always set by Twitch (when clearing the whole chat, no user is targeted), so you shouldn't non-null-assert it.
There was a problem hiding this comment.
This was my thought while writing this
There was a problem hiding this comment.
onTypedMessage is a public method, so messages can be accessed by anyone, and then it can definitely be null here.
|
Thank you for the feedback I will rewrite it tomorrow 😃 |
d-fischer
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Improvement
Fixes: #308
While rewriting my chat logger from tmi.js to Twurple, I noticed that some documented and undocumented tags were missing.
PS: This is my first GitHub contribution and PR and I hope I respected your dev style (some code I did not understand so I am leaving it as is)