Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate auth requests #318

Closed
d-fischer opened this issue Jan 11, 2022 · 0 comments · Fixed by #320
Closed

Deduplicate auth requests #318

d-fischer opened this issue Jan 11, 2022 · 0 comments · Fixed by #320
Milestone

Comments

@d-fischer
Copy link
Member

AuthProvider instances sometimes get many requests at once in production workloads. That causes them to request a lot of tokens at once.

This can possibly result in:

  • spamming id.twitch.tv with requests
  • in extreme cases, saving a token that is getting invalidated by too many other tokens being created
  • opening many dialog boxes (e.g. Electron)

We aim to get rid of this problem by only sending a single request and reusing that request for responding to all other calls as well.

Definitely consider what happens with requests that require new scopes after the request has already been sent - it might require some sort of scope queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant