Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce 'stoud' + 'logs' sink #77

Merged
merged 8 commits into from Jan 22, 2022
Merged

feat: Introduce 'stoud' + 'logs' sink #77

merged 8 commits into from Jan 22, 2022

Conversation

scarmuega
Copy link
Member

@scarmuega scarmuega commented Jan 21, 2022

this PR will introduce two new sinks:

  • 'stdout': which is a very basic sink that writes events directly into the stdout stream, one event per line, using json format
  • 'logs': which appends events into a local files, with configurable rotation and optional compression

@scarmuega scarmuega changed the title feat: Introduce 'writer' sink feat: Introduce 'stoud' + 'logs' sink Jan 21, 2022
@mark-stopka mark-stopka self-assigned this Jan 22, 2022
@scarmuega scarmuega self-assigned this Jan 22, 2022
@scarmuega scarmuega marked this pull request as ready for review January 22, 2022 12:48
@scarmuega scarmuega merged commit cdaa738 into main Jan 22, 2022
@scarmuega scarmuega deleted the feat/stdout branch January 22, 2022 12:48
@mark-stopka
Copy link
Collaborator

I was hopeing to fix it and learn something in a meanwhile 😅 I guess I'll have to revisit the changes you made

@scarmuega
Copy link
Member Author

@mark-stopka sorry, was actively working to close the feature today. Feel free to open a new PR if you already caught any bugs. My goal is to leave a pre-release version of this new sink running on a server for a few days as a way to validate performance over a long period of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants