Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module support #672

Closed
wants to merge 1 commit into from
Closed

Conversation

Foxboron
Copy link

The weird replace rules is because of a dependency with a weird import
path.

Signed-off-by: Morten Linderud morten@linderud.pw

The weird replace rules is because of a dependency with a weird import
path.

Signed-off-by: Morten Linderud <morten@linderud.pw>
@txthinking
Copy link
Owner

txthinking commented Mar 29, 2020

Thanks, but If go get works well, I prefer the simple way, not go mod.
I think the authors of the original unix department of the go team have designed simple and the best way. It is go get.
I know go get maybe increase our work, when your imported libs change, so just change our code. I like the stupid way.

@txthinking txthinking closed this Mar 29, 2020
@Foxboron
Copy link
Author

@txthinking go get doesn't work well at all. The problem is that you are unable to track library changes over time, which result in broken software down the line. Downstream distributions like Arch Linux can't reproduce the software, as in recreate the exact package bit-for-bit identical, which prevents us from having additional security guarantees for our users.

@txthinking txthinking reopened this Mar 29, 2020
@walterk2020
Copy link

H

@Foxboron
Copy link
Author

Foxboron commented Jan 29, 2021

No response and the files are outdated anyway.

EDIT:

And GOPATH is going to be deprecated soon anyway so go get isn't going to work regardless going forward.

@Foxboron Foxboron closed this Jan 29, 2021
@txthinking
Copy link
Owner

golang/go#31529

@txthinking
Copy link
Owner

etcd-io/etcd#11154

@txthinking txthinking reopened this Feb 12, 2021
@1715173329
Copy link
Contributor

However this is required since go 1.13, and will be forced in go 1.17.

btw, please bump urfave/cli to v2 so it will compile with go >= 1.15.

@txthinking txthinking closed this in 4c460be Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants