Skip to content

Commit

Permalink
Merge pull request #35 from ty-ras/issue/33-fix-misc-things
Browse files Browse the repository at this point in the history
#33 Fixing various thigns which were forgotten fr…
  • Loading branch information
stazz committed Aug 23, 2023
2 parents 9b3bff5 + 94d0f7f commit a43efd5
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 10 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,13 @@ jobs:
# Run build *after* tests - since tests no longer require transpiled JS to run
# We still want to run build to catch any TS error possibly lurking somewhere.
# Because we test first and build then, we can do compilation without __tests__ directory.
# We re-add it to src folder in order to include it in published NPM package (if CD pipeline).
# Notice we must produce stub package.json file to dist-cjs folder, otherwise `require` will fail on relative imports within the dist-cjs folder.
- id: compile
name: Compile ${{ matrix.dir }}
shell: bash
run: |
set -e
./scripts/build.sh '${{ matrix.dir }}' ci
if [[ -d '${{ matrix.dir }}/dist-cjs' ]]; then
sudo chmod -R o=rwX '${{ matrix.dir }}/dist-cjs'
cat '${{ matrix.dir }}/package.json' | jq -M 'del(.files, .type, .main, .module, .types, .exports)' > '${{ matrix.dir }}/dist-cjs/package.json'
fi
- id: lint
name: Lint ${{ matrix.dir }}
Expand Down
2 changes: 1 addition & 1 deletion server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ty-ras/server-node",
"version": "2.1.0",
"version": "2.1.1",
"author": {
"name": "Stanislav Muhametsin",
"email": "346799+stazz@users.noreply.github.com",
Expand Down
1 change: 1 addition & 0 deletions server/src/cors.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* @file This file contains code which exposes Node server -specific CORS handler creation function.
*/

/* c8 ignore next 13 */
import * as server from "@ty-ras/server";
import * as internal from "./internal";
Expand Down
1 change: 1 addition & 0 deletions server/src/internal.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* @file This file contains internal code for e.g. implementing Node HTTP server -specific functionality of {@link server.ServerFlowCallbacksWithoutState}.
*/

import type * as server from "@ty-ras/server";
import type * as ctx from "./context.types";
import type * as http from "node:http";
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"module": "ESNext",
"moduleResolution": "node",
"lib": [
"ESNext"
"ES2022"
],
"target": "ESNext",
"target": "ES2022",
"esModuleInterop": true,
// No code minimization/uglification is happening, thus preserving source maps does not bring much value.
// Furthermore, because .js and .mjs files will reside in the same directory, there will be a little hassle on the mapping file names + their refs in source.
Expand Down

0 comments on commit a43efd5

Please sign in to comment.