Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old code in AudioStim #309

Merged
merged 3 commits into from Jul 21, 2018
Merged

Removed old code in AudioStim #309

merged 3 commits into from Jul 21, 2018

Conversation

qmac
Copy link
Collaborator

@qmac qmac commented Jul 20, 2018

In light of moviepy being released with our patch (Zulko/moviepy#665), we can go ahead and remove this bit of code to hack AudioStim sampling rate.

Requires users to install the newest version of moviepy.

Librosa on 2.7 still failing, not sure what's taking the new release so long.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.384% when pulling a2b21fc on moviepy-update into f6dc7a1 on master.

Copy link
Collaborator

@tyarkoni tyarkoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update requirements.txt to require a minimum version of moviepy? Looks great otherwise!

@qmac qmac merged commit cfd43d4 into master Jul 21, 2018
@qmac qmac deleted the moviepy-update branch July 21, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants