Memory leak

[ghost]

[sanity.c:252]: (error) Memory leak: apic_ids
[sanity.c:252]: (error) Memory leak: apic_copy

[tycho]

Not sure why this issue was closed so quickly. I've just committed a fix in a332865.

[ghost]

hm.. interesting

[sanity.c:246]: (error) Deallocating a deallocated pointer: apic_ids
[sanity.c:247]: (error) Deallocating a deallocated pointer: apic_copy

[tycho]

Oh. Oops. It was freed already after those for loops... How were these "leaks" detected?

[ghost]

@tycho

$ cd cpuid-master
$ cppcheck --enable=performance -v . 2> performance.log
$ cat performance.log

Debug mode:

[sanity.c:246]: (error) Deallocating a deallocated pointer: apic_ids
[sanity.c:247]: (error) Deallocating a deallocated pointer: apic_copy
[sanity.c:126]: (debug) inconclusive leak of apic_state: ; assign ; alloc ; loop use ; dealloc ; return ; }
[sanity.c:128]: (debug) inconclusive leak of busy_workers: ; assign ; alloc ; loop use ; dealloc ; return ; }
[sanity.c:129]: (debug) inconclusive leak of apic_workers: ; assign ; alloc ; loop use ; dealloc ; return ; }

[tycho]

I looked more closely at the codepath. The 'goto cleanup' skips over the deallocations if there's duplicate APIC IDs. I've fixed it up.

[ghost]

@tycho, Thanks FixIt.