Fix use of undefined pointer types in definitions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyiki-badwell
added a commit
that referenced
this pull request
Mar 13, 2021
* feat(ftl-sdk): updating to new best endpoint and docker builds Added Docker Build Added call to new Best v2 endpoint Added more verbose logging and error handling Added use of linter Increase the length of vendor name and version * adding execute into git for scripts * cmake: Use external jansson if possible * cmake: Install into standard directories * cmake: Install a pkgconfig file * Add instructions for generating compatible audio/video streams (#2) The original links to download a demuxed version of Sintel are all broken links now, I think this is a reasonable set of options to start with and I confirmed the outputs work with `ftl_app`, though the audio seems to get out of sync. This of course can be further improved but it's a step towards Glimesh/janus-ftl-plugin#43 to have a single-purpose tool that sends a stream to ingest. Co-authored-by: Nathaniel von Sprecken <navonsp@microsoft.com> Co-authored-by: Jan Alexander Steffens (heftig) <jsteffens@make.tv> Co-authored-by: Hayden McAfee <hayden@outlook.com> Co-authored-by: Daniel Stiner <daniel.stiner+github@gmail.com>
tyiki-badwell
pushed a commit
that referenced
this pull request
Mar 21, 2021
The original links to download a demuxed version of Sintel are all broken links now, I think this is a reasonable set of options to start with and I confirmed the outputs work with `ftl_app`, though the audio seems to get out of sync. This of course can be further improved but it's a step towards Glimesh/janus-ftl-plugin#43 to have a single-purpose tool that sends a stream to ingest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.