This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Fix deadlock in Stop function. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Stop() is called before the interrupt channel is created in Serve(), it will block forever. This commit creates the interrupt channel in Stop() or Serve(), whichever comes first. It uses the same logic as StopChan(), and reuses StopChan's mutex for locking.
|
Nice catch! Thanks for the PR!! |
tylerstillwater
pushed a commit
that referenced
this pull request
Apr 22, 2015
Fix deadlock in Stop function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Stop() is called before the interrupt channel is created in Serve(), it will block forever. This commit creates the interrupt channel in Stop() or Serve(), whichever comes first. It uses the same logic as StopChan(), and reuses StopChan's mutex for locking.