Skip to content

Commit

Permalink
[ZEPPELIN-4280] [Followup] Add comments
Browse files Browse the repository at this point in the history
### What is this PR for?
This is followup issue for ZEPPELIN-4280, to add some comments on the code.

### What type of PR is it?
Documentation

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4280

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes apache#3461 from Leemoonsoo/ZEPPELIN-4280-followup and squashes the following commits:

75d4995 [Lee moon soo] add comment

(cherry picked from commit 7d74b92)
Signed-off-by: Lee moon soo <moon@apache.org>
  • Loading branch information
Leemoonsoo committed Sep 27, 2019
1 parent 5f29db1 commit e2e1d19
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -802,9 +802,13 @@ function ResultCtrl($scope, $rootScope, $route, $window, $routeParams, $location
newConfig.graph.values = newConfig.graph.commonSetting.pivot.values;
delete newConfig.graph.commonSetting.pivot;
}

// don't send commitParagraphResult when config is the same.
// see https://issues.apache.org/jira/browse/ZEPPELIN-4280.
if (angular.equals($scope.config, newConfig)) {
return;
}

console.debug('committVizConfig', newConfig);
let newParams = angular.copy(paragraph.settings.params);
commitParagraphResult(paragraph.title, paragraph.text, newConfig, newParams);
Expand Down

0 comments on commit e2e1d19

Please sign in to comment.