Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive logs leftovers #66

Closed
FriendsOfGalaxy opened this issue Dec 16, 2019 · 1 comment
Closed

Sensitive logs leftovers #66

FriendsOfGalaxy opened this issue Dec 16, 2019 · 1 comment

Comments

@FriendsOfGalaxy
Copy link
Contributor

Hey,

there is a place in code which will log sensitive info regardless of the LOG_SENSITIVE_DATA variable.

async def pass_login_credentials(self, step, credentials, cookies):
log.debug("ROCKSTAR_COOKIE_LIST: " + str(cookies))
for cookie in cookies:
........

tylerbrawl added a commit that referenced this issue Dec 18, 2019
Added game launch fallback for outdated launcher clients (see #65) and added safe sensitive data catch (see #66).
@tylerbrawl
Copy link
Owner

Good catch. I made sure to implement that for this version and push it to fog_release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants