Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text link not accessible #25

Closed
weboverhauls opened this issue Jun 1, 2016 · 5 comments
Closed

Text link not accessible #25

weboverhauls opened this issue Jun 1, 2016 · 5 comments

Comments

@weboverhauls
Copy link

The text link is not fully accessible since it relies on color alone to denote that it's a link.

Suggestion 1: return the underline. (highly recommended)

Suggestion 2: provide more visual affordance that the standalone text is a link such as adding an icon.

WCAG references:
http://www.w3.org/TR/2008/REC-WCAG20-20081211/#visual-audio-contrast-without-color
http://www.w3.org/TR/WCAG20-TECHS/F73.html

PS:
Since this is a link, strange that it's listed under Buttons and the class names say button.

image

@thisconnect
Copy link

Suggestion 1: return the underline. (highly recommended)

I agree especially because all other links in cutestrap have the underlines

Suggestion 2: provide more visual affordance that the standalone text is a link such as adding an icon.

One should be free to choose an icon set, so I hope cutestrap does NOT include icons

Since this is a link, strange that it's listed under Buttons and the class names say button.

Other frameworks use button style link as well.

@tylerchilds
Copy link
Owner

Definitely will add the underline, that was just an oversight of mine when developing.

Won't be adding icons, but I might build a light weight icon set at some point in the future to be used in conjunction with cutestrap.

@patrickhlauke
Copy link
Contributor

Since this is a link, strange that it's listed under Buttons and the class names say button.

I'd suggest that, to make it clearer, the example should add the btn--link class to a <button>, and the <a> should get another class like btn instead...

@patrickhlauke
Copy link
Contributor

...something like

<button>Default</button>
<button class="btn--secondary">Secondary</button>
<button class="btn--link">Link</button>
<a class="btn" href="#">Link styled as button</a>

cute-btns

@tylerchilds
Copy link
Owner

Resolved in version 2, also everything will have a focus outline by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants