-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding EDID to config.plist #60
Comments
@velaar What method did you use to create this EDID? I want to add instructions on the repo for others to follow for their own display. |
@tylernguyen It is a bit involved.
|
@velaar It's also working on my machine. That's great, it seems all HDR screens on the x1c6 may be the same after all. Furthermore, you fixed my other headache, the damn framebuffer patching. It seems that an EDID override will fix an issue where HDMI hotplug will result in an internal black screen. Thanks so much for contributing again @velaar . I will update the repo soon with a |
@tylernguyen Did you try the overclocked refresh rates? My display works 100% only up to 64Hz. 65Hz there are refresh artifacts and 66Hz the picture is garbage. But even at 64Hz that is almost 7% refresh rate increase. Not much, but feels great to have the machine a little tiny bit different :) |
@velaar My experience is the same as yours. 66Hz and the display will go crazy. 65Hz will have artifacts. Would you like to remove those two from the EDID and leave 64Hz since it's the only one that seems to be stable? If that's too much trouble, I'm fine with adding the current EDID override to the repo and leaving a note. |
@tylernguyen
UNTESTED though, but should work. You might also keep 66Hz for adventurous people who might have a display from a different batch. |
@velaar Noted. I will just update the repo with the original patch and leave a note then. If you don't mind, it would be great if you could leave more details on the first two steps (dumping the EDID and patching refresh rate in Windows). I want it to be as easy as possible for others to follow this issue and create pull requests for other display models. *Note for future display patches: correct EDID profile should fix the following problems:
|
@tylernguyen will do. But no time today unfortunately.
It worked only the first time this way. Maybe because of the one-key-hidpi but starting with the run 2 I again get the black screen. Can you please confirm that it is consistent for you? |
@velaar You're right. The FileVault issue will reappear after a few reboots. I've edited my comment above. |
For the FHD display the EDID is the following:
Works fine on my computer for HDMI hotplug. I can't say anything about FileVault because I haven't enabled it yet. |
Thanks @Paolo97Gll I'll add it to the repo on the next commit. I think that the only EDID missing is the one for the regular non-HDR 1440p screen. |
@tylernguyen @velaar after enabling FileVault, I also confirm the bug you reported. |
@velaar 's EDID with 60,62,63,64 Hz options works for me on macOS 11.2.2 with xzhih/one-key-hidpi option 1 Enable HIDPI without patch. Before that, I had some strange issue with the repo's EDID that includes the 66 Hz option where I could choose any of the refresh rates except when I was on the "Default" scaling, which was stuck at 66 Hz with the drop-down disabled. Since 66 Hz caused screen tearing and artifacts, I couldn't use default scaling, until I used @velaar 's EDID. That removed 66 Hz as an option, and also for some reason the refresh rate drop-down also became enabled ¯_(ツ)_/¯ Anyway thanks! |
@tylernguyen I'm talking about his 64 Hz one, the last one he shared in this thread. This one:
|
Please test the attached EDID. I added 65Hz in and it works well on my laptop.
ONLY for HDR screen.
<key>AAPL00,override-no-connect</key> <data>AP///////wAwrq5AAAAAAAAbAQSQHxF44vvVplM0tiUOUFQAAAABAQEBAQEBAQEBAQEBAQEB5l8AoKCgQFAwIDUAgGghAAAYj2YAoKCgLVAwIDUAgGghAAAY22cAoKCgKVAwIDUAgGghAAAYMGUAoKCgMFAwIDUAgGghAAAYADc=</data>
The text was updated successfully, but these errors were encountered: