-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use babel-plugin-lodash to redue bundle size #8
base: master
Are you sure you want to change the base?
Conversation
I don't get the same results for some reason. Before:
After:
Maybe just importing the needed modules individually (i.e. |
@fabiospampinato on a second try with a clean yarn.lock I get similar results to yours. I think the entire lodash is coming from graphlibrary dependency. https://github.com/tylingsoft/graphlibrary/blob/master/lib/lodash.js |
With node_modules excluded from babel-loader,
With node_modules included in babel-loader,
I think we can save more if we can fix graphlibrary tylingsoft/graphlibrary#4 |
With graphlibrary patched like tylingsoft/graphlibrary#5 bundle size actually increased!
|
Did you try loading lodash in the same way in this library too? I don't think Another detail worth mentioning is that is important to make sure that there's only 1 non-deduplicated instance of |
Fix for #5 using babel-plugin-lodash
Before,
After,