Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWTAuth::getToken() signature change is not yet documented #1652

Closed
itsnotvalid opened this issue Aug 27, 2018 · 0 comments
Closed

JWTAuth::getToken() signature change is not yet documented #1652

itsnotvalid opened this issue Aug 27, 2018 · 0 comments

Comments

@itsnotvalid
Copy link

Subject of the issue

Since milestone 1.0.0-rc.2, on commit 7c1d58e there is additional changes to the values returned by JWTAuth::getToken(). This function is suggested to be used in the 0.5.0 doc (wiki: https://github.com/tymondesigns/jwt-auth/wiki/Authentication ) as a way to obtain the token.

However, it's now returning false instead of null.

Please document this in breaking changes so others unlike me would be notified of the changes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant