Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9.x Compatibility #2168

Closed

Conversation

laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/jwt-auth.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "tymon/jwt-auth": "dev-l9-compatibility",
    }
}

Finally, run: composer update

@@ -14,8 +14,8 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [7.2, 7.3, 7.4, 8.0]
laravel: [6.*, 7.*, 8.*]
php: [7.2, 7.3, 7.4, 8.0, 8.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error, 8.0 is now twice

@mfn
Copy link
Contributor

mfn commented Feb 12, 2022

FTR, all these necessary changes are part of https://github.com/PHP-Open-Source-Saver/jwt-auth already

@jasonmccreary
Copy link

@mfn, yeah this came in a bit late as we realized some of the automation didn't work for packages where the repository was under a different name.

Feel free to close.

@mfn
Copy link
Contributor

mfn commented Feb 13, 2022

@jasonmccreary I've no stake / permissions here, can't close :-}

@mohamed-foly
Copy link

+1

@mohamed-foly
Copy link

I forked and applied the required updates
composer require mohamed-foly/jwt-auth:dev-laravel-9
https://packagist.org/packages/mohamed-foly/jwt-auth#dev-laravel-9

@mfn
Copy link
Contributor

mfn commented Mar 4, 2022

FTR, as mentioned in #2168 (comment) , this is already part of a community fork ❗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants