Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to change the download URL #201

Merged
merged 3 commits into from
Jul 2, 2021

Conversation

ynx-zeissl
Copy link
Contributor

In order to cache the mockingbird package on a local server and downloading it from there, the hardcoded github link must be changeable.
I havn't tried this MR locally so please review it.
Link to my already created Feature Request: #200

@andrewchang-bird
Copy link
Contributor

Thanks for the PR! I’ve made a few changes and verified that it works locally:

% make install
% mockingbird download starter-pack 
Downloading asset bundle from https://github.com/birdrides/mockingbird/releases/download/0.16.0/MockingbirdSupport.zip
Temporary asset bundle data stored at file:///var/folders/27/f9qsltsn4dd53snd2tpr9rkh0000gn/T/CFNetworkDownload_GQSSnj.tmp
Extracting downloaded asset bundle to /Users/typealias/mockingbird
Successfully loaded asset bundle 'starter-pack' into /Users/typealias/mockingbird
% mockingbird download starter-pack --url https://github.com/birdrides/mockingbird/releases/download
Downloading asset bundle from https://github.com/birdrides/mockingbird/releases/download/0.16.0/MockingbirdSupport.zip
Temporary asset bundle data stored at file:///var/folders/27/f9qsltsn4dd53snd2tpr9rkh0000gn/T/CFNetworkDownload_SrJYeC.tmp
Extracting downloaded asset bundle to /Users/typealias/mockingbird
Successfully loaded asset bundle 'starter-pack' into /Users/typealias/mockingbird

@andrewchang-bird andrewchang-bird merged commit f59a8f8 into typealiased:master Jul 2, 2021
@ynx-zeissl
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants