[3/n] Change default thunk pruning level to 'omit' #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewchang-bird
force-pushed
the
thunk-pruning-default
branch
from
3927a97
to
3188a75
Compare
andrewchang-bird
changed the title
ryanmeisters
approved these changes
Jul 9, 2021
Although the parser+generator is relatively mature, the surface area of source changes with the potential to cause broken generated mocks is still quite large. To improve the developer experience and initial setup process, this change flips the default thunk pruning level from 'stub' which still generates *declarations* for unused types, to 'omit' which only creates mocks for referenced types in tests. See also: typealiased#174
andrewchang-bird
force-pushed
the
thunk-pruning-default
branch
from
3188a75
to
7c961b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the parser+generator is relatively mature, the surface area of source changes with the potential to cause broken generated mocks is still quite large. To improve the developer experience and initial setup process, this change flips the default thunk pruning level from 'stub' which still generates declarations for unused types, to 'omit' which only creates mocks for referenced types in tests.
See also: #174