[3/n] Remove protocol extension methods #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmeisters
approved these changes
Jul 9, 2021
Although methods defined in protocol extensions can be re-defined in a conforming type, static dispatch means that the original method will always be called. Currently the generator creates mocking code for protocol extensions which was leading to unexpected results in tests for stubbing and verification.
andrewchang-bird
force-pushed
the
remove-protocol-extension-methods
branch
from
09b1313
to
14af898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although methods defined in protocol extensions can be re-defined in a conforming type, static dispatch means that the original method will always be called. Currently the generator creates mocking code for protocol extensions which was leading to unexpected results in tests for stubbing and verification.