Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3/n] Improve parsing of function parameter attributes #208

Merged
merged 1 commit into from
Jul 10, 2021
Merged

[3/n] Improve parsing of function parameter attributes #208

merged 1 commit into from
Jul 10, 2021

Conversation

andrewchang-bird
Copy link
Contributor

Function parameter attributes without whitespace between the attribute and the type annotation currently fail to parse correctly, e.g.

func foo(bar: @escaping(String) -> Void)
func foo(bar: @escaping@autoclosure() -> String)

@andrewchang-bird andrewchang-bird added this to the Release 0.17 milestone Jul 3, 2021
@andrewchang-bird andrewchang-bird changed the title Improve parsing of function parameter attributes [3/n] Improve parsing of function parameter attributes Jul 3, 2021
@andrewchang-bird
Improve parsing of function parameter attributes
6f32c70 
Function parameter attributes without whitespace between the attribute
and the type annotation currently fail to parse correctly, e.g.

```swift
func foo(bar: @escaping(String) -> Void)
func foo(bar: @escaping@autoclosure() -> String)
```
@andrewchang-bird andrewchang-bird merged commit 387836c into typealiased:master Jul 10, 2021
@andrewchang-bird andrewchang-bird deleted the parse-function-attr branch July 10, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmeisters ryanmeisters ryanmeisters approved these changes

@shackley shackley Awaiting requested review from shackley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.17
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewchang-bird @ryanmeisters