[4/x] Fix nested optional property and Obj-C types #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2022
ryanmeisters
approved these changes
Jan 19, 2022
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/add-static-typechecking
branch
from
57eeb30
to
f308e36
Compare
Base automatically changed from
dev/andrewchang-bird/add-static-typechecking
to
master
January 19, 2022 20:39
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-nullability-handling
branch
from
6ac5ed9
to
6f51908
Compare
andrewchang-bird
deleted the
dev/andrewchang-bird/fix-nullability-handling
branch
andrewchang-bird
added a commit
that referenced
this pull request
Jan 19, 2022
Returning `nil` from a nested optional property or Objective-C member
incorrectly applies additional optional wrapping due to coercion to
`Any?`.
```swift
protocol Foo {
var nested: Int?? { get }
}
given(myMock.nested).willReturn(nil)
print(myMock.nested) // Prints "Optional(nil)" instead of "nil"
XCTAssertNil(myMock.nested) // Fails
```
This PR replaces the `Any?` coercion with `Any` when creating a new
dynamic stub.
- Added additional optionals tests for both the trivial `nil` case and
returning a wrapped `nil`
- CI tests pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
📚 #275 [5/x] Clean up Synchronized wrapper
📚 #274 ← [4/x] Fix nested optional property and Obj-C types
📚 #273 [3/x] Improve compile-time checks for Swift mocks
📚 #272 [2/x] Remove Obj-C based nil check
📚 #271 [1/x] Add Algolia DocSearch to the documentation
Overview
Returning
nilfrom a nested optional property or Objective-C member incorrectly applies additional optional wrapping due to coercion toAny?.This PR replaces the
Any?coercion withAnywhen creating a new dynamic stub.Test Plan
nilcase and returning a wrappednil