Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support initializer verification #280

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Support initializer verification #280

merged 3 commits into from
Jan 26, 2022

Conversation

myihsan
Copy link
Contributor

@myihsan myihsan commented Jan 25, 2022

Overview

Resolve #240.

Test Plan

Testing by InitializerTests.testInitializerVerification.

andrewchang-bird
andrewchang-bird approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@andrewchang-bird andrewchang-bird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me. Once it’s rebased on master I’ll merge it in.

@andrewchang-bird andrewchang-bird merged commit 20a520f into typealiased:master Jan 26, 2022
@andrewchang-bird andrewchang-bird added this to the Release 0.20 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewchang-bird andrewchang-bird andrewchang-bird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.20
Development

Successfully merging this pull request may close these issues.

Unable to verify initializer since 0.18.0
2 participants
@myihsan @andrewchang-bird