[3/y] Fix read-only subscripts #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Jan 27, 2022
ryanmeisters
approved these changes
Jan 28, 2022
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-initializer-warnings
branch
from
bec1ac2
to
b558190
Compare
Base automatically changed from
dev/andrewchang-bird/fix-initializer-warnings
to
master
January 28, 2022 21:09
andrewchang-bird
force-pushed
the
dev/andrewchang-bird/fix-readonly-subscripts
branch
from
5d87836
to
4b54adc
Compare
andrewchang-bird
deleted the
dev/andrewchang-bird/fix-readonly-subscripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
📚 #287 [5/y] Improve static mocking APIs
📚 #286 [4/y] Enable mocking sources in test bundles
📚 #285 ← [3/y] Fix read-only subscripts
📚 #284 [2/y] Fix warnings in throwing initializers
📚 #283 [1/y] Add backwards compatibility with Swift 5.5
Overview
Read-only subscripts were incorrectly generating setter thunks which weren’t caught by the test suite due to the generic
Equatableoverload. This adds thereadonlyattribute as needed when parsing subscript methods using similar logic as properties.Closes #281
Test Plan
Fixed read-only subscript tests and added an additional case for setters marked as (file)private.