-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with the new javascript module api #39
Comments
@bartocc I believe what we'll need to do is update the typings in the Definitely Typed repo for that. We'll need to come up with a strategy for defining the imports at both locations in some way or another, given that we're certain to have some users on the old and some on the new import paths. 🤔 |
@chriskrycho that's roughly what I thought. But I am not familiar with the Definitely Typed repo and the way |
Unfortunately, it's generated by hand. It's a matter of forking the repo and then updating this file. I started on some tweaks a few weeks ago (before I went on vacation) but ran into a number of issues there around extracting the |
Work on this has started and I'll add updates here early next week with links to the places where it's in work so people can help. |
Watch for a PR at https://github.com/typed-ember/ember-typings/pulls adding these in the next few days. The work is done, just need to land a few other pieces first! |
RFC: https://github.com/emberjs/rfcs/blob/master/text/0176-javascript-module-api.md
generates an error :
[ts] Cannot find module '@ember/component'.
This import is possible thanks to ember-cli/ember-cli-shims#92 available in https://github.com/ember-cli/ember-cli-shims/releases/tag/v1.2.0-beta.2.
How can we make typescript aware of those new modules ?
The text was updated successfully, but these errors were encountered: