-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new module shims #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'm super excited to be moving forward here!
A few notes/comments:
- Remove JSHint usage (if we want linting, we should use eslint).
- Ensure that all modules which use the global
Ember
import it properly (seems like many/most do not at this point). - Add deprecations to usages of generateModule for all "old" shims other than
ember
. - Remove old shim for
rsvp
andjquery
should these be implemented in the ember-source addon itself? |
@martndemus Can you add a shim for PR: #93 |
@martndemus @rwjblue Hmm ... you're right I'm not sure what the procedure here is. The RFC has already been merged, but clearly |
Any updates about this ? |
would it be possible for the deprecation messages to explicitly mention the new path so that you don't have to look it up manually all the time? |
Yeah, that does sound nice. We should also probably also have the deprecation link back to a section on the README here so that we can provide more "prosey" explanations... |
I mentioned on Slack that we also have an automatic migration tool, which might be preferable to adding that logic here as well. |
Merged as discussed in the Ember CLI team meeting yesterday. We will release this as a beta today and then continue from there. |
🎉 |
@locks asked me to PR this.