Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update configuration.md to include an example of generating sourcemaps with Embroider #1391

Merged
merged 3 commits into from Feb 4, 2022

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Dec 8, 2020

I had to add devtool to my webpackConfig in order for sourcemaps to be generated of my typescript files with Embroider.

Not sure if this documentation belongs here or in the embroider docs (or whether there are other/better ways to set up the config)

Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great—thank you!

I had to add devtool to my webpackConfig in order for  sourcemaps to be
generated of my typescript files with Embroider.

Not sure if this documentation belongs here or in the embroider docs (or
whether there are other/better ways to set up the config)
@chriskrycho
Copy link
Member

(Note: I updated the branch here so it passes our commit lint setup. I'm likely going to turn that off in the future, as it's not really adding value to us, esp. for things like this.)

@chriskrycho chriskrycho merged commit c36cfd3 into typed-ember:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants