Ignore no-empty-interface in the default app index.d.ts #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in:
https://discord.com/channels/480462759797063690/484421406659182603/917815976244953151
eslint will coerce the empty interface for
Arrayintypes/__app_name__/index.d.tsinto a type forArray, which breaks things. Theno-empty-interfacerule should not be binned, andindex.d.tsshould not be added to.eslintignore.The rule's role is to prevent subtyping without any changes, so if
Arraywere to extend two types, that would be another solution, but I don't know if merging the Ember array with some pretend other type is a good idea.