Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ember-cli-htmlbars #1519

Merged
merged 1 commit into from Sep 2, 2022
Merged

Switch to ember-cli-htmlbars #1519

merged 1 commit into from Sep 2, 2022

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Jul 28, 2022

Switch from deprecated package to replacement.

ember-cli-htmlbars-inline-precompile
Deprecated
Usage of this project is deprecated, its functionality has been migrated into ember-cli-htmlbars directly. Please upgrade to ember-cli-htmlbars@4.0.3 or higher.

Note: @types/htmlbars-inline-precompile is still present and I haven't touched that as I don't think there's a renamed/replacement package for its types (yet).

chriskrycho
chriskrycho reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmish thanks for this one as well! This also looks good, but in this case I do want to get a CI run on it – can you rebase and push here? And then ping me tomorrow in Discord if I don't merge it, please!

@bmish bmish force-pushed the ember-cli-htmlbars branch 2 times, most recently from 2af1d71 to 3944628 Compare August 29, 2022 14:22
@dfreeman
Copy link
Member

Note: @types/htmlbars-inline-precompile is still present and I haven't touched that as I don't think there's a renamed/replacement package for its types

We should be able to drop @types/htmlbars-inline-precompile, as ember-cli-htmlbars ships its own types.

@bmish
Copy link
Contributor Author

bmish commented Aug 29, 2022

@dfreeman good point, I removed @types/htmlbars-inline-precompile.

@bmish
Copy link
Contributor Author

bmish commented Aug 30, 2022

@chriskrycho the CI failures appear to be unrelated to this PR.

@chriskrycho
Copy link
Member

Ugh, okay, I merged the other one; can you merge or rebase, and I'll merge this one as well?

@bmish
Copy link
Contributor Author

bmish commented Sep 2, 2022

@chriskrycho done.

@chriskrycho chriskrycho closed this Sep 2, 2022
@bmish
Copy link
Contributor Author

bmish commented Sep 2, 2022

@chriskrycho unintentionally closed?

@chriskrycho chriskrycho reopened this Sep 2, 2022
@chriskrycho chriskrycho merged commit 7f10d23 into typed-ember:master Sep 2, 2022
@chriskrycho chriskrycho added the dependencies Pull requests that update a dependency file label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmish @dfreeman @chriskrycho