This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
[WIP] ember-decorators #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwickern
force-pushed
the
ember-decorators
branch
from
afc4cbe
to
741fc96
Compare
This was referenced Aug 23, 2017
|
Hey @dwickern I'm willing to help here ! Do you need me to ping you on slack ? |
|
@bartocc I'd appreciate the help! I made this branch to get things started for anyone who wants to contribute. We're in slack if you have any questions |
…corators # Conflicts: # types/ember-decorators/index.d.ts
mike-north
reviewed
Dec 20, 2017
| } | ||
|
|
||
| declare module 'ember-decorators/object' { | ||
| export function computed(...keys: string[]): MethodDecorator; |
There was a problem hiding this comment.
needs to be a PropertyDecorator as well
export function computed(...dependentKeys: string[]): PropertyDecorator;
export function computed(target: any, propertyKey: string | symbol): void;
|
@dwickern |
|
I'm not sure this issue is relevant any more given that ember decorators are written in TS now. @pzuraq ? |
|
ember-decorators are not actually written in TS, they are compatible now. If we can add the typings there I’m completely ok with it, either way |
|
Yeah, we should close this issue. You can check the pull requests on the specific repositories I opened over the weekend! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this as a starting point for
ember-decoratorstypings. I'm putting the typings here to leverage DT's test framework. Ultimately these typings belong in the ember-decorators repo.I've found that typescript decorators are severely limited in what they can express. I'll try to document some of those issues and possible workarounds.
I based this branch on the
new-object-modelbranch since the typings didn't work on master (withoutnoImplicitAnyor some extra type annotations).