Merge pull request #666 from patricklx/fix-windows

fix windows tests

.github/workflows/ci.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Locate Yarn Cache
         id: yarn-cache-dir-path
         run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
@@ -60,7 +60,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Install Dependencies
         uses: nick-fields/retry@v2
         with:
@@ -93,7 +93,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Install Dependencies
         run: yarn install --no-lockfile
       - name: Build
@@ -112,7 +112,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - name: Locate Yarn Cache
         id: yarn-cache-dir-path
         run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT

package.json

@@ -36,7 +36,7 @@
   },
   "resolutions": {
     "@types/yargs": "17.0.13",
-    "@types/node": "^18.11.5",
+    "@types/node": "^20.10.6",
     "ember-cli-htmlbars": "^6.0.1"
   },
   "version": "1.2.1"

packages/vscode/package.json

@@ -107,8 +107,8 @@
     "@glint/core": "^1.2.1",
     "@types/mocha": "^10.0.1",
     "@types/vscode": "^1.68.1",
-    "@vscode/test-electron": "2.2.0",
-    "@vscode/vsce": "^2.19.0",
+    "@vscode/test-electron": "^2.3.8",
+    "@vscode/vsce": "^2.22.0",
     "esbuild": "^0.15.16",
     "expect": "^29.5.0",
     "mocha": "^10.2.0",

test-packages/ts-ember-app/tsconfig.json

@@ -24,7 +24,7 @@
     "baseUrl": ".",
     "module": "es6",
     "experimentalDecorators": true,
-    "isolatedModules": true,
+    "isolatedModules": false, //TODO: reset to `true` when @types/node supports this for nightly ts
     "paths": {
       "ts-ember-app/tests/*": ["tests/*"],
       "ts-ember-app/*": ["app/*"],