-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helper and modifier helpers #412
Conversation
Thank you! One of us will review this week! |
@patricklx thanks again for opening this; mind fixing up the CI failures? I'll try to review tomorrow or Friday! |
Thank you for opening this, @patricklx! In addition to the things flagged in CI, I think these are going to need to be a bit more complex to capture what You can see an example of how this works with the Is that something you've got the time/interest to take on? If so, great, and let us know if you need any additional guidance. If not, no worries—Chris or I should hopefully be able to get to it in the near future. |
I just noticed that these two: <div {{(if true (modifier "on" "click" this.func))}}></div>
<div {{(if true (modifier "on")) "click" this.func}}></div> Actually mean the same thing so Glint should somehow support them both. No idea how. 😄 |
Yep! Those two examples should fall out naturally and "just work" assuming we implement the currying semantics of those two helpers I mentioned above 🙂 |
Hi @patricklx! Would you be able to pick up the suggestion from @dfreeman how to overcome missing parts here? |
Actually, I believe @dfreeman is working on getting these done. From Discord:
🎉 |
fixes #410
the documentation for them is not published yet. It should be there when 4.7 is published:
emberjs/ember.js@d75a0cb