build: migrate to yarn v4 #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JounQin
commented
Jan 6, 2024
| @@ -0,0 +1,3 @@ | |||
| nodeLinker: node-modules | |||
|
|
|||
| yarnPath: .yarn/releases/yarn-4.0.2.cjs | |||
There was a problem hiding this comment.
Not using corepack because it does not work quite well with Windows.
There was a problem hiding this comment.
Apparently there is some aversion to corepack as well
There was a problem hiding this comment.
does this file need to be checked in? wouldn't it come from an npm package?
There was a problem hiding this comment.
It can be enabled via corepack, but the usage is a bit strict. The current approach is much flexible.
See also #671 (comment)
wouldn't it come from an npm package?
It's not in npm.
| @@ -8,6 +8,6 @@ export default class Greeting extends Component<GreetingSignature> { | |||
| private message = 'Hello'; | |||
|
|
|||
| <template> | |||
| {{this.message}}, {{@target}}! | |||
| {{@undocumentedProperty}} {{this.message}}, {{@target}}! | |||
There was a problem hiding this comment.
I don't know, I just run yarn test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A promise from https://twitter.com/JounQin/status/1743647752045690975
close #670