Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project argument to match tsc #709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix project argument to match tsc #709

wants to merge 2 commits into from

Commits on Mar 14, 2024

  1. Fix project argument to match tsc 

    The `--project` argument was being treated as a path to some location inside the project, rather than as either a path to a tsconfig file or a path to a folder containing a tsconfig file, which is how `tsc` implements it. This meant that there was no way to run `glint` and use a config file named anything other than `tsconfig.json`.

This is a breaking change because if anybody was passing a project path that pointed deeply into the project, that will no longer work. Similarly, the `analyzeProject()` unstable API's behavior has changed, and `loadConfig` export has been replaced with `loadClosestConfig` and `loadConfigFromProject` exports.
    @bendemboski
    bendemboski committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6740357 View commit details
    Browse the repository at this point in the history

  2. (to rebase) Address PR feedback

    @bendemboski
    bendemboski committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f9dd5ba View commit details
    Browse the repository at this point in the history