Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make mxText assignable to mxShape #35

Merged
merged 2 commits into from
Apr 19, 2021
Merged

fix: make mxText assignable to mxShape #35

merged 2 commits into from
Apr 19, 2021

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 9, 2021

Some fields were redeclared as protected whereas there are public in the mxShape
super class.


Introduced in 1.0.1 by #32
Detected with process-analytics/bpmn-visualization-js#1224

cc @csouchet @aibcmars

tbouffard and others added 2 commits April 9, 2021 11:01
Some fields were redeclared as protected whereas there are public in the mxShape
super class.
@hungtcs
Copy link
Member

hungtcs commented Apr 19, 2021

Hi @tbouffard, these parameters are inferred from mxText.js#L65-L86, it seems that all properties should be public, I added a patch to to modify all of them.

@hungtcs hungtcs merged commit ded620f into master Apr 19, 2021
@hungtcs hungtcs deleted the fix/mxText_type branch April 19, 2021 03:35
@tbouffard
Copy link
Member Author

@hungtcs thanks for merging and the patch.
About protected visibility, I introduced it in #32 and I don't remember why I didn't set it to public. But anyway, you fix it for good: there was no reason to put them protected and we don't have protected elsewhere in the rest of the types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants